Homec4science

Allow projects to review revisions

Authored by epriestley <git@epriestley.com> on Oct 5 2013, 04:57.

Description

Allow projects to review revisions

Summary:
Ref T1279. No actual logical changes, but:

  • You can now add projects as reviewers from the revision view typeahead ("Add Reviewers" action).
  • You can now add projects as reviewers from the revision detail typeahead.
  • You can now add projects as reviewers from the CLI (#yoloswag).
  • Generated commit messages now list project reviewers (Reviewers: #yoloswag).

I'll separate projects from users in the "Reviewers" tables in the next revision.

Test Plan:

  • Added projects as reviewers using the web UI and CLI.
  • Used arc amend --show --revision Dnnn to generate commit messages.
  • Viewed revision with project reviewers in web UI.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D7230

Details

Committed
epriestley <git@epriestley.com>Oct 5 2013, 23:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH370c7635a788: Track "accepted" and "commented" in per-reviewer status
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcf4eb3109e77: Allow projects to review revisions (authored by epriestley <git@epriestley.com>).Oct 5 2013, 23:10