Homec4science

Fix bug when multiple comment forms appear on a single page

Authored by epriestley <git@epriestley.com> on Jul 29 2013, 03:21.

Description

Fix bug when multiple comment forms appear on a single page

Summary:
Ref T3373. The submit listener doesn't properly scope the form it listens to right now, so several forms on the page mean that comments post to one of them more or less at random.

Scope it properly by telling it which object PHID it is associated with.

Test Plan: Made Question comments, saw comments Ajax in on the question itself rather than on an arbitrary answer.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3373

Differential Revision: https://secure.phabricator.com/D6611

Details

Committed
epriestley <git@epriestley.com>Jul 29 2013, 21:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb6130ad49e48: Restore Ponder question commenting
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcf9dc5d18945: Fix bug when multiple comment forms appear on a single page (authored by epriestley <git@epriestley.com>).Jul 29 2013, 21:04