Homec4science

Validate timezones

Authored by epriestley <git@epriestley.com> on Jan 2 2013, 23:02.

Description

Validate timezones

Summary:
Add validation for timezones, since date_default_timezone_set() returns a usable error code.

Note that we could also list all the timezones using timezone_identifiers_list(), but the list is enormous (many hundreds of entries) and impossible to use (~160 entries in "America" alone). I listed the likely US values as examples but left it as a string input text field.

Test Plan: Tried to save an invalid setting. Saved a valid setting.

Reviewers: codeblock, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2255

Differential Revision: https://secure.phabricator.com/D4318

Details

Committed
epriestley <git@epriestley.com>Jan 2 2013, 23:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9c41ea960946: Add some more options to the "core" group.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcff043a80083: Validate timezones (authored by epriestley <git@epriestley.com>).Jan 2 2013, 23:02