Homec4science

Use exceptions for S3 error messages

Authored by epriestley <git@epriestley.com> on Aug 4 2011, 17:09.

Description

Use exceptions for S3 error messages

Summary:
Right now, the "SimpleEmailService" class uses trigger_error() to communicate
error messages. This means they get lost in the error logs and aren't visible in
the MetaMTA interface.

Provide a flag to strengthen them into exceptions, instead.

(I've attempted to emulate the prevailing style so I can offer this upstream.)

Test Plan: Faked an error condition and got a detailed stack trace in MetaMTA
instead of an empty "Message" field.
Reviewed By: jungejason
Reviewers: hunterbridges, codeblock, jungejason, tuomaspelkonen, aran
CC: aran, jungejason
Differential Revision: 783

Details

Committed
epriestley <git@epriestley.com>Aug 4 2011, 23:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc7e1fa626d75: Fix typo in Celerity mapper
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd064c6efa803: Use exceptions for S3 error messages (authored by epriestley <git@epriestley.com>).Aug 4 2011, 23:17