Homec4science

Fix countdown embeds and endless loops on resource loads in Javelin

Authored by epriestley <git@epriestley.com> on Jun 6 2014, 02:16.

Description

Fix countdown embeds and endless loops on resource loads in Javelin

Summary:
Fixes T5273. Two issues:

  • If a JX.Resource callback throws, we keep running it. Instead, make sure it gets cleaned up before raising an exception.
  • The countdown timer script doesn't recover gracefully if the node has been removed from the document by the time it runs. Instead, just bail if we can't find the countdown.

Test Plan: Dumped {Cxyz} into a preview and got a countdown.

Reviewers: yungsters

Reviewed By: yungsters

Subscribers: epriestley

Maniphest Tasks: T5273

Differential Revision: https://secure.phabricator.com/D9399

Details

Committed
epriestley <git@epriestley.com>Jun 6 2014, 02:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfcc2a24d63e6: Update Aphlict documentation for new server management commands
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd06679a0214c: Fix countdown embeds and endless loops on resource loads in Javelin (authored by epriestley <git@epriestley.com>).Jun 6 2014, 02:16