Homec4science

Break AphrontWriteGuard dependency on AphrontRequest

Authored by epriestley <git@epriestley.com> on Jul 24 2012, 00:17.

Description

Break AphrontWriteGuard dependency on AphrontRequest

Summary:
I want to move queryfx() and family to libphutil, for @chad and others (see T1283). We need to break a few dependencies to do this.

Since AphrontWriteGuard is independently useful, I broke the dependency between it and AphrontRequest rather than between Connection and WriteGuard. I'll move its implementation to libphutil in a future diff.

Test Plan: Loaded site, submitted CSRF form successfully, monkeyed with CSRF token, submitted CSRF form, got error.

Reviewers: btrahan, vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1283

Differential Revision: https://secure.phabricator.com/D3042

Details

Committed
epriestley <git@epriestley.com>Jul 24 2012, 00:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8213a70f3d68: Fix "fullName" rules for Maniphest transaction email
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd07934474ee3: Break AphrontWriteGuard dependency on AphrontRequest (authored by epriestley <git@epriestley.com>).Jul 24 2012, 00:17