Homec4science

Fix string construction in Conduit exceptions

Authored by epriestley <git@epriestley.com> on Aug 11 2014, 21:08.

Description

Fix string construction in Conduit exceptions

Summary:
Fixes T5838.

  • We currently try to use a ConduitAPIMethod object as a string.
  • We then pass that string to the parent's __construct() method as $message.

Test Plan: Uninstalled Maniphest, then tried to execute maniphest.createtask. Got a useful exception message instead of an error during message construction.

Reviewers: joshuaspence, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5838

Differential Revision: https://secure.phabricator.com/D10211

Details

Committed
epriestley <git@epriestley.com>Aug 11 2014, 21:08
Pushed
aubortJan 31 2017, 17:16
Branches
Unknown
Tags
Unknown
[cURL/7] (http://10.0.1.35:80/api/diffusion.commitparentsquery) <CURLE_COULDNT_CONNECT> The cURL library raised an error while making a request. You may be able to find more information about this error (error code: 7) on the cURL site: http://curl.haxx.se/libcurl/c/libcurl-errors.html#CURLECOULDNTCONNECT

Event Timeline

epriestley <git@epriestley.com> committed rPHd09d7ffe1f2e: Fix string construction in Conduit exceptions (authored by epriestley <git@epriestley.com>).Aug 11 2014, 21:08