Add "final" to (almost) everything else
d0af617818b6
Actions

Authored by epriestley <git@epriestley.com> on Mar 14 2012, 00:21.

Description

Add "final" to (almost) everything else

Summary: Last of the big final patches. Left a few debatable classes (12 out of about 400) that I'll deal with individually eventually.

Test Plan: Ran testEverythingImplemented.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1881

Details

Committed

epriestley <git@epriestley.com>

Mar 14 2012, 00:21

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH7c9057854b4b: [svn1.7] Fix thrown exception when browsing diffusion with added directories

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd0af617818b6: Add "final" to (almost) everything else (authored by epriestley <git@epriestley.com>).Mar 14 2012, 00:21

Changes (182)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path
	M			src/applications/base/storage/configuration/DatabaseConfigurationProvider.php
	M			src/applications/conduit/storage/methodcalllog/PhabricatorConduitMethodCallLog.php
	M			src/applications/herald/adapter/commit/HeraldCommitAdapter.php
	M			src/applications/herald/adapter/differential/HeraldDifferentialRevisionAdapter.php
	M			src/applications/herald/adapter/dryrun/HeraldDryRunAdapter.php
	M			src/applications/herald/config/action/HeraldActionConfig.php
	M			src/applications/herald/config/condition/HeraldConditionConfig.php
	M			src/applications/herald/config/contenttype/HeraldContentTypeConfig.php
	M			src/applications/herald/config/field/HeraldFieldConfig.php
	M			src/applications/herald/config/repetitionpolicy/HeraldRepetitionPolicyConfig.php
	M			src/applications/herald/config/ruletype/HeraldRuleTypeConfig.php
	M			src/applications/herald/config/valuetype/HeraldValueTypeConfig.php
	M			src/applications/herald/engine/effect/HeraldEffect.php
	M			src/applications/herald/engine/engine/HeraldEngine.php
	M			src/applications/herald/engine/engine/exception/HeraldInvalidConditionException.php
	M			src/applications/herald/engine/engine/exception/HeraldInvalidFieldException.php
	M			src/applications/herald/engine/engine/exception/HeraldRecursiveConditionsException.php
	M			src/applications/herald/storage/action/HeraldAction.php
	M			src/applications/herald/storage/condition/HeraldCondition.php
	M			src/applications/herald/storage/edithistory/HeraldRuleEdit.php
	M			src/applications/herald/storage/rule/HeraldRule.php
	M			src/applications/herald/storage/transcript/apply/HeraldApplyTranscript.php
	M			src/applications/herald/storage/transcript/base/HeraldTranscript.php
	M			src/applications/herald/storage/transcript/condition/HeraldConditionTranscript.php
	M			src/applications/herald/storage/transcript/object/HeraldObjectTranscript.php
	M			src/applications/herald/storage/transcript/rule/HeraldRuleTranscript.php
	M			src/applications/maniphest/auxiliaryfield/typeexception/ManiphestAuxiliaryFieldTypeException.php
	M			src/applications/maniphest/auxiliaryfield/validationexception/ManiphestAuxiliaryFieldValidationException.php
	M			src/applications/maniphest/constants/action/ManiphestAction.php
	M			src/applications/maniphest/constants/base/ManiphestConstants.php
	M			src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php
	M			src/applications/maniphest/replyhandler/ManiphestReplyHandler.php
	M			src/applications/maniphest/storage/auxiliary/ManiphestTaskAuxiliaryStorage.php
	M			src/applications/maniphest/storage/base/ManiphestDAO.php
	M			src/applications/maniphest/storage/task/ManiphestTask.php
	M			src/applications/maniphest/storage/transaction/ManiphestTransaction.php
	M			src/applications/maniphest/view/tasklist/ManiphestTaskListView.php
	M			src/applications/maniphest/view/tasksummary/ManiphestTaskSummaryView.php
	M			src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php
	M			src/applications/maniphest/view/transactionlist/ManiphestTransactionListView.php
	M			src/applications/metamta/adapter/amazonses/PhabricatorMailImplementationAmazonSESAdapter.php
	M			src/applications/metamta/adapter/phpmailerlite/PhabricatorMailImplementationPHPMailerLiteAdapter.php
	M			src/applications/metamta/adapter/sendgrid/PhabricatorMailImplementationSendGridAdapter.php
	M			src/applications/metamta/adapter/test/PhabricatorMailImplementationTestAdapter.php
	M			src/applications/metamta/storage/mail/PhabricatorMetaMTAAttachment.php
	M			src/applications/metamta/storage/mail/PhabricatorMetaMTAMail.php
	M			src/applications/metamta/storage/mail/__tests__/PhabricatorMetaMTAMailTestCase.php
	M			src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php
	M			src/applications/metamta/storage/receivedmail/PhabricatorMetaMTAReceivedMail.php
	M			src/applications/owners/query/path/PhabricatorOwnerPathQuery.php
	M			src/applications/owners/storage/owner/PhabricatorOwnersOwner.php
	M			src/applications/owners/storage/package/PhabricatorOwnersPackage.php
	M			src/applications/owners/storage/path/PhabricatorOwnersPath.php
	M			src/applications/paste/storage/paste/PhabricatorPaste.php
	M			src/applications/people/storage/log/PhabricatorUserLog.php
	M			src/applications/people/storage/preferences/PhabricatorUserPreferences.php
	M			src/applications/people/storage/profile/PhabricatorUserProfile.php
	M			src/applications/people/storage/user/PhabricatorUser.php
	M			src/applications/people/storage/useroauthinfo/PhabricatorUserOAuthInfo.php
	M			src/applications/people/storage/usersshkey/PhabricatorUserSSHKey.php
	M			src/applications/phid/handle/PhabricatorObjectHandle.php
	M			src/applications/phid/handle/const/status/PhabricatorObjectHandleStatus.php
	M			src/applications/phid/handle/data/PhabricatorObjectHandleData.php
	M			src/applications/phid/handle/view/selector/PhabricatorHandleObjectSelectorDataView.php
	M			src/applications/phid/storage/base/PhabricatorPHIDDAO.php
	M			src/applications/phid/storage/phid/PhabricatorPHID.php
	M			src/applications/phriction/constants/action/PhrictionActionConstants.php
	M			src/applications/phriction/storage/content/PhrictionContent.php
	M			src/applications/phriction/storage/document/PhrictionDocument.php
	M			src/applications/phriction/storage/document/__tests__/PhrictionDocumentTestCase.php
	M			src/applications/project/storage/affiliation/PhabricatorProjectAffiliation.php
	M			src/applications/project/storage/base/PhabricatorProjectDAO.php
	M			src/applications/project/storage/profile/PhabricatorProjectProfile.php
	M			src/applications/project/storage/project/PhabricatorProject.php
	M			src/applications/project/storage/transaction/PhabricatorProjectTransaction.php
	M			src/applications/repository/daemon/commitdiscovery/git/PhabricatorRepositoryGitCommitDiscoveryDaemon.php
	M			src/applications/repository/daemon/commitdiscovery/mercurial/PhabricatorRepositoryMercurialCommitDiscoveryDaemon.php
	M			src/applications/repository/daemon/commitdiscovery/svn/PhabricatorRepositorySvnCommitDiscoveryDaemon.php
	M			src/applications/repository/daemon/committask/PhabricatorRepositoryCommitTaskDaemon.php
	M			src/applications/repository/parser/default/PhabricatorRepositoryDefaultCommitMessageDetailParser.php
	M			src/applications/repository/storage/arcanistproject/PhabricatorRepositoryArcanistProject.php
	M			src/applications/repository/storage/base/PhabricatorRepositoryDAO.php
	M			src/applications/repository/storage/commit/PhabricatorRepositoryCommit.php
	M			src/applications/repository/storage/commitdata/PhabricatorRepositoryCommitData.php
	M			src/applications/repository/storage/repository/PhabricatorRepository.php
	M			src/applications/repository/storage/shortcut/PhabricatorRepositoryShortcut.php
	M			src/applications/repository/storage/symbol/PhabricatorRepositorySymbol.php
	M			src/applications/repository/worker/commitchangeparser/git/PhabricatorRepositoryGitCommitChangeParserWorker.php
	M			src/applications/repository/worker/commitchangeparser/mercurial/PhabricatorRepositoryMercurialCommitChangeParserWorker.php
	M			src/applications/repository/worker/commitmessageparser/git/PhabricatorRepositoryGitCommitMessageParserWorker.php
	M			src/applications/repository/worker/commitmessageparser/mercurial/PhabricatorRepositoryMercurialCommitMessageParserWorker.php
	M			src/applications/repository/worker/commitmessageparser/svn/PhabricatorRepositorySvnCommitMessageParserWorker.php
	M			src/applications/repository/worker/herald/PhabricatorRepositoryCommitHeraldWorker.php
	M			src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php
	M			src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php
	M			src/applications/search/index/indexer/maniphest/PhabricatorSearchManiphestIndexer.php
	M			src/applications/search/index/indexer/phriction/PhabricatorSearchPhrictionIndexer.php
	M			src/applications/search/index/indexer/repository/PhabricatorSearchCommitIndexer.php
	M			src/applications/search/index/indexer/user/PhabricatorSearchUserIndexer.php
	M			src/applications/search/storage/document/document/PhabricatorSearchDocument.php
	M			src/applications/search/storage/document/field/PhabricatorSearchDocumentField.php
	M			src/applications/search/storage/document/relationship/PhabricatorSearchDocumentRelationship.php
	M			src/applications/slowvote/storage/base/PhabricatorSlowvoteDAO.php
	M			src/applications/slowvote/storage/choice/PhabricatorSlowvoteChoice.php
	M			src/applications/slowvote/storage/comment/PhabricatorSlowvoteComment.php
	M			src/applications/slowvote/storage/option/PhabricatorSlowvoteOption.php
	M			src/applications/slowvote/storage/poll/PhabricatorSlowvotePoll.php
	M			src/applications/uiexample/examples/client/JavelinViewExample.php
	M			src/applications/uiexample/examples/client/JavelinViewExampleServerView.php
	M			src/applications/uiexample/examples/listfilter/PhabricatorUIListFilterExample.php
	M			src/applications/uiexample/examples/pager/PhabricatorUIPagerExample.php
	M			src/applications/uiexample/examples/reactor/JavelinReactorExample.php
	M			src/applications/xhpastview/storage/parsetree/PhabricatorXHPASTViewParseTree.php
	M			src/infrastructure/daemon/garbagecollector/PhabricatorGarbageCollectorDaemon.php
	M			src/infrastructure/daemon/irc/handler/differentialnotification/PhabricatorIRCDifferentialNotificationHandler.php
	M			src/infrastructure/daemon/irc/handler/objectname/PhabricatorIRCObjectNameHandler.php
	M			src/infrastructure/daemon/irc/handler/protocol/PhabricatorIRCProtocolHandler.php
	M			src/infrastructure/daemon/storage/event/PhabricatorDaemonLogEvent.php
	M			src/infrastructure/daemon/storage/log/PhabricatorDaemonLog.php
	M			src/infrastructure/daemon/timeline/cursor/iterator/PhabricatorTimelineIterator.php
	M			src/infrastructure/daemon/timeline/storage/base/PhabricatorTimelineDAO.php
	M			src/infrastructure/daemon/timeline/storage/cursor/PhabricatorTimelineCursor.php
	M			src/infrastructure/daemon/timeline/storage/event/PhabricatorTimelineEvent.php
	M			src/infrastructure/daemon/timeline/storage/eventdata/PhabricatorTimelineEventData.php
	M			src/infrastructure/daemon/workers/storage/task/PhabricatorWorkerTask.php
	M			src/infrastructure/daemon/workers/storage/taskdata/PhabricatorWorkerTaskData.php
	M			src/infrastructure/daemon/workers/taskmaster/PhabricatorTaskmasterDaemon.php
	M			src/infrastructure/daemon/workers/worker/goodfornothing/PhabricatorGoodForNothingWorker.php
	M			src/infrastructure/events/engine/PhabricatorEventEngine.php
	M			src/infrastructure/lint/engine/PhabricatorLintEngine.php
	M			src/infrastructure/lint/hook/xhpastsymbolname/PhabricatorSymbolNameLinter.php
	M			src/infrastructure/lint/linter/javelin/PhabricatorJavelinLinter.php
	M			src/infrastructure/markup/remarkup/markuprule/differential/PhabricatorRemarkupRuleDifferential.php
	M			src/infrastructure/markup/remarkup/markuprule/diffusion/PhabricatorRemarkupRuleDiffusion.php
	M			src/infrastructure/markup/remarkup/markuprule/embedobject/PhabricatorRemarkupRuleEmbedFile.php
	M			src/infrastructure/markup/remarkup/markuprule/imagemacro/PhabricatorRemarkupRuleImageMacro.php
	M			src/infrastructure/markup/remarkup/markuprule/maniphest/PhabricatorRemarkupRuleManiphest.php
	M			src/infrastructure/markup/remarkup/markuprule/mention/PhabricatorRemarkupRuleMention.php
	M			src/infrastructure/markup/remarkup/markuprule/paste/PhabricatorRemarkupRulePaste.php
	M			src/infrastructure/markup/remarkup/markuprule/phriction/PhabricatorRemarkupRulePhriction.php
	M			src/infrastructure/markup/remarkup/markuprule/proxyimage/PhabricatorRemarkupRuleProxyImage.php
	M			src/infrastructure/markup/remarkup/markuprule/youtube/PhabricatorRemarkupRuleYoutube.php
	M			src/infrastructure/setup/PhabricatorSetup.php
	M			src/infrastructure/testing/testcase/__tests__/PhabricatorTrivialTestCase.php
	M			src/storage/connection/isolated/AphrontIsolatedDatabaseConnection.php
	M			src/storage/connection/isolated/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php
	M			src/storage/connection/mysql/AphrontMySQLDatabaseConnection.php
	M			src/storage/exception/accessdenied/AphrontQueryAccessDeniedException.php
	M			src/storage/exception/base/AphrontQueryException.php
	M			src/storage/exception/connection/AphrontQueryConnectionException.php
	M			src/storage/exception/connectionlost/AphrontQueryConnectionLostException.php
	M			src/storage/exception/count/AphrontQueryCountException.php
	M			src/storage/exception/duplicatekey/AphrontQueryDuplicateKeyException.php
	M			src/storage/exception/objectmissing/AphrontQueryObjectMissingException.php
	M			src/storage/exception/parameter/AphrontQueryParameterException.php
	M			src/storage/exception/recoverable/AphrontQueryRecoverableException.php
	M			src/storage/lisk/dao/__tests__/LiskIsolationTestCase.php
	M			src/storage/lisk/dao/__tests__/LiskIsolationTestDAO.php
	M			src/storage/lisk/dao/__tests__/LiskIsolationTestDAOException.php
	M			src/view/control/objectselector/PhabricatorObjectSelectorDialog.php
	M			src/view/control/table/AphrontTableView.php
	M			src/view/control/tokenizer/AphrontTokenizerTemplateView.php
	M			src/view/control/typeahead/AphrontTypeaheadTemplateView.php
	M			src/view/dialog/AphrontDialogView.php
	M			src/view/form/control/checkbox/AphrontFormCheckboxControl.php
	M			src/view/form/control/divider/AphrontFormDividerControl.php
	M			src/view/form/control/draganddropupload/AphrontFormDragAndDropUploadControl.php
	M			src/view/form/control/file/AphrontFormFileControl.php
	M			src/view/form/control/markup/AphrontFormMarkupControl.php
	M			src/view/form/control/password/AphrontFormPasswordControl.php
	M			src/view/form/control/recaptcha/AphrontFormRecaptchaControl.php
	M			src/view/form/control/select/AphrontFormSelectControl.php
	M			src/view/form/control/static/AphrontFormStaticControl.php
	M			src/view/form/control/submit/AphrontFormSubmitControl.php
	M			src/view/form/control/text/AphrontFormTextControl.php
	M			src/view/form/control/textarea/AphrontFormTextAreaControl.php
	M			src/view/form/control/togglebuttons/AphrontFormToggleButtonsControl.php
	M			src/view/form/control/tokenizer/AphrontFormTokenizerControl.php
	M			src/view/javelin-view/AphrontJavelinView.php
	M			src/view/page/base/AphrontPageView.php
	M			src/view/page/standard/PhabricatorStandardPageView.php
	M			src/view/widget/keyboardshortcuts/AphrontKeyboardShortcutsAvailableView.php