Homec4science

Pholio - fix a bug replacing multiple images

Authored by Bob Trahan <bob.trahan@gmail.com> on Nov 9 2013, 02:13.

Description

Pholio - fix a bug replacing multiple images

Summary: these transactions should never merge since they are always created for a 1:1 replacement. (ie any merging would be implicitly erroneous). Fixes T4081

Test Plan: made a mock with three images and replaced all three successfully. replaced image A with image B, did not save, replaced image B with image C, then saved and verified transaction correctly showed image A replaced with image C.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4081

Differential Revision: https://secure.phabricator.com/D7536

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Nov 9 2013, 02:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7ffea0463e42: Use herald to trigger builds of revisions and commits.
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHd0de4dab2416: Pholio - fix a bug replacing multiple images (authored by Bob Trahan <bob.trahan@gmail.com>).Nov 9 2013, 02:13