Homec4science

Add Disabled mode to landing revision ui

Authored by Aviv Eyal <avivey@gmail.com> on Jan 30 2014, 18:07.

Description

Add Disabled mode to landing revision ui

Summary:
Fixes T4066.

add isActionDisabled() to DifferentialLandingStrategy, which also explains why it is so.
Make an appropriate pop-up in the controller.

Also make the whole UI "workflow", and convert createMenuItems() to createMenuItem() (Singular).

Test Plan: Click "Land to..." button in all kinds of revisions.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4066

Differential Revision: https://secure.phabricator.com/D8105

Details

Committed
epriestley <git@epriestley.com>Jan 30 2014, 18:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6b4998bf4beb: Increment copyright year and add 2017 dates to calendar import script
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd0e30882a11f: Add Disabled mode to landing revision ui (authored by Aviv Eyal <avivey@gmail.com>).Jan 30 2014, 18:07