Homec4science

Add `diffusion.querycommits` and deprecate `diffusion.getcommits`

Authored by epriestley <git@epriestley.com> on Jan 28 2014, 02:14.

Description

Add diffusion.querycommits and deprecate diffusion.getcommits

Summary:
Fixes T4344. diffusion.getcommits is nasty old bad news. Implement a modern query method.

This method provides limit/paging in a somewhat abstract way so it's sort of ultramodern, but I didn't want the default behavior to return a million rows. I'll probably move more stuff toward this over time, now that cursor paging is pervasive. Here, we needed extra metadata (the identifier map) anyway.

Test Plan: Used console to execute command.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4344

Differential Revision: https://secure.phabricator.com/D8077

Details

Committed
epriestley <git@epriestley.com>Jan 28 2014, 02:14
Pushed
aubortJan 31 2017, 17:16
Parents
rPH152f05aebed0: Fix some security issues with email password resets
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd112b6c15d8e: Add `diffusion.querycommits` and deprecate `diffusion.getcommits` (authored by epriestley <git@epriestley.com>).Jan 28 2014, 02:14