Homec4science

Mark IMPORTED_CHANGE more consistently

Authored by epriestley <git@epriestley.com> on Nov 1 2013, 20:54.

Description

Mark IMPORTED_CHANGE more consistently

Summary:
See https://github.com/facebook/phabricator/issues/425. There are some ways that the change parsers may not reach finishParse(), but we now need them to in order to mark the commit imported, advance the progress bar, and eventually kick the repository out of IMPORTING status.

Take all the copy/pasted code in the parsers and move it into the parent. Specifically, this is:

  • Printing a status message about starting a parse;
  • checking for bad commits;
  • queueing the next parse stage; and
  • marking the import step complete.

Test Plan: Used reparse.php --change to reparse Git, SVN and Mercurial repos.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7470

Details

Committed
epriestley <git@epriestley.com>Nov 1 2013, 20:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH43fd567ef471: Implement writes over HTTP for Git.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd1649d176f67: Mark IMPORTED_CHANGE more consistently (authored by epriestley <git@epriestley.com>).Nov 1 2013, 20:54