Homec4science

Reuse common getUser() / setUser() in PHUICalendarListView

Authored by epriestley <git@epriestley.com> on Feb 25 2014, 03:55.

Description

Reuse common getUser() / setUser() in PHUICalendarListView

Summary:
These methods already exist in AphrontView. The redefinition can sometimes cause this warning:

[2014-02-24 18:27:48] ERROR 2048: Declaration of PHUICalendarListView::setUser() should be compatible with AphrontView::setUser(PhabricatorUser $user) at [/INSECURE/devtools/phabricator/src/view/phui/calendar/PHUICalendarListView.php:138]

Test Plan: Viewed calendar on profile.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D8329

Details

Committed
epriestley <git@epriestley.com>Feb 25 2014, 03:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4eadcf975ade: Implement most Differential actions against ApplicationTransactions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd19e2155be0b: Reuse common getUser() / setUser() in PHUICalendarListView (authored by epriestley <git@epriestley.com>).Feb 25 2014, 03:55