Homec4science

Clean up Diffusion branch query a bit

Authored by epriestley <git@epriestley.com> on Oct 30 2013, 21:06.

Description

Clean up Diffusion branch query a bit

Summary:
Ref T2716.

  • Serve from DiffusionCommitQuery, not PhabricatorAuditCommitQuery (which should probably die).
  • Fix logic for limit, which incorrectly failed to display the "Showing %d branches." text.
  • Clean up things a touch.
  • I didn't end up actually needing needCommitData(), but left it in there since I think it will be needed soon.
  • Removed a "TODO" because I don't remember what "etc etc" means.

Test Plan: Looked at branches in several repositories.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2716

Differential Revision: https://secure.phabricator.com/D7451

Details

Committed
epriestley <git@epriestley.com>Oct 30 2013, 21:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH70b53c49fd0c: Fix an issue with viewing an undiscovered commit in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd1c4b5081cd0: Clean up Diffusion branch query a bit (authored by epriestley <git@epriestley.com>).Oct 30 2013, 21:06