Homec4science

Fix missing `willUpload` hook for drag-and-drop chunked upload

Authored by epriestley <git@epriestley.com> on Sep 9 2015, 01:20.

Description

Fix missing willUpload hook for drag-and-drop chunked upload

Summary:
Ref T9324. When you upload a normal file, we call willUpload and then didUpload.

When you upload a chunked file, we never call willUpload. This can get things out of sync. Make sure we invoke this event for both chunked and non-chunked uploads.

Test Plan: Got cleaner behavior (redirect after all uploads finish) in new Phacility file upload area.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9324

Differential Revision: https://secure.phabricator.com/D14083

Details

Committed
epriestley <git@epriestley.com>Sep 9 2015, 01:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7425407c126b: Improve `bin/config set` errors for complex values
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd2374c468fdc: Fix missing `willUpload` hook for drag-and-drop chunked upload (authored by epriestley <git@epriestley.com>).Sep 9 2015, 01:20