Homec4science

Conpherence - implement PhabricatorDestructibleInterface so threads can be…

Authored by Bob Trahan <btrahan@phacility.com> on Apr 8 2015, 21:19.

Description

Conpherence - implement PhabricatorDestructibleInterface so threads can be deleted

Summary: Fixes T7694. I had to complicate the ConpherenceThreadQuery code slightly so that if we specify id(s) or phid(s) then we don't bother with all that join stuff we need to make sure we have a reasonable query in production.

Test Plan: bin/remove destroy ZXX worked! tried to visit ZXX and got a nice 404. Clicked around and couldn't find anything broken because of the deletion

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7756, T7694

Differential Revision: https://secure.phabricator.com/D12304

Details

Committed
Bob Trahan <btrahan@phacility.com>Apr 8 2015, 21:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8fc45e1774a6: Diffusion - further fix translation of revert commit stories
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHd24b3dcb7de3: Conpherence - implement PhabricatorDestructibleInterface so threads can be… (authored by Bob Trahan <btrahan@phacility.com>).Apr 8 2015, 21:19