Homec4science

Don't fatal on duplicate field in commit message

Authored by vrana <jakubv@fb.com> on Sep 11 2012, 02:09.

Description

Don't fatal on duplicate field in commit message

Summary:
If the actual commit message has a duplicate field and we shouldAutoclose it then the commit message parser fails.
Put the error in $errors instead.

Test Plan:
Reparsed commit with duplicate field in message.
Tried to arc diff message with duplicate field.

Reviewers: epriestley, nh

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3470

Details

Committed
vrana <jakubv@fb.com>Sep 11 2012, 02:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPH99949bec8dc7: Link Phabricator tests
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHd28c591e7450: Don't fatal on duplicate field in commit message (authored by vrana <jakubv@fb.com>).Sep 11 2012, 02:24