Homec4science

Use Workflow, not Request, for Differential populate/show more requests

Authored by epriestley <git@epriestley.com> on Jul 16 2011, 16:09.

Description

Use Workflow, not Request, for Differential populate/show more requests

Summary: When a JX.Request fails, there's no default error handling. Rather than
write some kind of custom stuff, just use JX.Workflow so we get exception
dialogs. We have plans to enhance these anyway (see T302).
Test Plan: Changed the changeset view controller to throw exceptions. Verified I
got un-mysterious exception dialogs when a changeset failed because of an
exception in either initial rendering or after hitting "see more".
Reviewed By: tomo
Reviewers: jungejason, tuomaspelkonen, aran, tomo
CC: aran, epriestley, tomo
Differential Revision: 679

Details

Committed
epriestley <git@epriestley.com>Jul 17 2011, 04:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5e00d00cf79f: Show more information on revision views
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd2954dae407b: Use Workflow, not Request, for Differential populate/show more requests (authored by epriestley <git@epriestley.com>).Jul 17 2011, 04:15