Homec4science

include revision id in getdiff conduit call

Authored by mgummelt <mgummelt@fb.com> on Aug 10 2011, 00:02.

Description

include revision id in getdiff conduit call

Summary:
we need to know the revision id in order to generate
differential links. It would be amazing if there existed some library
for object <-> network call mapping, and we could get all the
information about an object given some unique ID rather than having to
create a dictionary manually. One can dream...

Test Plan:

  1. setup on test phabricator instance
  2. called differential.getdiff from client code with a valid diffid
  3. verified that the correct revisionID was included

Reviewed By: epriestley
Reviewers: epriestley
CC: dpepper, aran, epriestley, mgummelt
Differential Revision: 795

Details

Committed
mgummelt <mgummelt@fb.com>Aug 10 2011, 00:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb8e08f34f7ae: Provide an indirection layer between documents and the search engine
Branches
Unknown
Tags
Unknown

Event Timeline

mgummelt <mgummelt@fb.com> committed rPHd3b8389256d3: include revision id in getdiff conduit call (authored by mgummelt <mgummelt@fb.com>).Aug 10 2011, 00:57