Homec4science

T494 Image displaye issue

Authored by Hua Wang <hwang36@gmail.com> on Sep 19 2011, 08:04.

Description

T494 Image displaye issue

Summary: The display of images pairs is not corresponding to the selected two
image diffs. The fix is to use reference to get the phid for each image.

Test Plan: Create a revision with two diffs of images.

Test the display between base and diff1/diff2.
Test the rendering of images between diff1 and diff2.
Test the inline comments also.

Reviewers: epriestley, jungejason

CC:

Differential Revision: 955

Details

Committed
Hua Wang <hwang36@gmail.com>Sep 30 2011, 09:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPH07f4772d0be4: Make all parsers use credentials
Branches
Unknown
Tags
Unknown

Event Timeline

Hua Wang <hwang36@gmail.com> committed rPHd41fd4a0fa21: T494 Image displaye issue (authored by Hua Wang <hwang36@gmail.com>).Sep 30 2011, 09:25