Homec4science

Make it harder to miss errors and warnings while developing Phabricator

Authored by epriestley <git@epriestley.com> on Jan 4 2012, 16:35.

Description

Make it harder to miss errors and warnings while developing Phabricator

Summary:
If a page generates warnings or errors, you only get a little red dot in
DarkConsole which is hard to see. DarkConsole is also fairly big and there are
plenty of reasons not to leave it open all the time.

Instead, unconditionally show a big message to developers if there are errors or
warnings.

We could make this more sophisticated eventually, but the value is just that you
see it.

Test Plan: Browsed pages with and without warnings, got the right banner state.

Reviewers: nh, btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Maniphest Tasks: T734

Differential Revision: https://secure.phabricator.com/D1307

Details

Committed
epriestley <git@epriestley.com>Jan 4 2012, 19:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH28b606394be4: Fix undefined variable warning in unit test field
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd43dec1d1288: Make it harder to miss errors and warnings while developing Phabricator (authored by epriestley <git@epriestley.com>).Jan 4 2012, 19:21