Homec4science

Send audit emails to more users

Authored by epriestley <git@epriestley.com> on Jul 10 2013, 20:18.

Description

Send audit emails to more users

Summary:
Audit has some weird rules about who gets email. Make them less weird:

  • When a user does "Add Auditors", email the auditors.
  • When a commit is commented on, email anyone in "concern" or "audit required" states.

@staticshock, my claim that I can't reproduce was crazy, I just have weird test data and read it wrong.

Test Plan: Added a user to an audit and verified they got an email.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: staticshock, aran

Differential Revision: https://secure.phabricator.com/D6414

Details

Committed
epriestley <git@epriestley.com>Jul 10 2013, 20:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc977168797cc: Show add reviewer typehead when user selects resign as a reviewer.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd467c49a66e8: Send audit emails to more users (authored by epriestley <git@epriestley.com>).Jul 10 2013, 20:18