Homec4science

Remove names from Drydock resources

Authored by epriestley <git@epriestley.com> on Oct 1 2015, 17:13.

Description

Remove names from Drydock resources

Summary:
Ref T9252. Long ago you sometimes manually created resources, so they had human-enterable names. However, users never make resources manually any more, so this field isn't really useful any more.

In particular, it means we write a lot of untranslatable strings like "Working Copy" to the database in the default locale. Instead, do the call at runtime so resource names are translatable.

Also clean up a few minor things I hit while kicking the tires here.

It's possible we might eventually want to introduce a human-choosable label so you can rename your favorite resources and this would just be a default name. I don't really have much of a use case for that yet, though, and I'm not sure there will ever be one.

Test Plan:

  • Restarted a Harbormaster build, got a clean build.
  • Released all leases/resources, restarted build, got a clean build with proper resource names.

Reviewers: hach-que, chad

Reviewed By: hach-que, chad

Maniphest Tasks: T9252

Differential Revision: https://secure.phabricator.com/D14213

Details

Committed
epriestley <git@epriestley.com>Oct 1 2015, 17:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb219bcfb3d70: Improve error and exception handling for Drydock leases
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd4a0b1c8709b: Remove names from Drydock resources (authored by epriestley <git@epriestley.com>).Oct 1 2015, 17:13