Homec4science

Formalize targets (users and channel) into objects

Authored by epriestley <git@epriestley.com> on Feb 14 2013, 14:13.

Description

Formalize targets (users and channel) into objects

Summary:
Make users/channels/rooms into objects, so we can later sort out stuff like Campfire user IDs, Phabricator vs chat accounts, etc.

The only change here is that I removed output buffering from the macro handler. We should move throttling/buffering to adapters instead and have it apply globally.

Test Plan: Ran IRC and Campfire bots and interacted with them.

Reviewers: indiefan

Reviewed By: indiefan

CC: aran

Differential Revision: https://secure.phabricator.com/D4924

Details

Committed
epriestley <git@epriestley.com>Feb 14 2013, 14:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPHec306497f54d: Lock down bot adapter API slightly
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd5995d574d86: Formalize targets (users and channel) into objects (authored by epriestley <git@epriestley.com>).Feb 14 2013, 14:13