Homec4science

Herald - fix change type bug

Authored by Bob Trahan <btrahan@phacility.com> on Apr 8 2014, 20:58.

Description

Herald - fix change type bug

Summary: wasn't working due to some type issues. Fixes T4756. I also made it display nicer while I was debugging this.

Test Plan: created a herald rule to block changes that added refs. git tag -a "test" -m "test test"; git push origin test got me blocked!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4756

Differential Revision: https://secure.phabricator.com/D8724

Details

Committed
Bob Trahan <btrahan@phacility.com>Apr 8 2014, 20:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH582ec5446532: Add a checkbox to the LDAP auth configuration UI to "Always Search"
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHd5ded805b2d3: Herald - fix change type bug (authored by Bob Trahan <btrahan@phacility.com>).Apr 8 2014, 20:58