Homec4science

Don't put objects into the query workspace by default

Authored by epriestley <git@epriestley.com> on Jul 1 2015, 19:47.

Description

Don't put objects into the query workspace by default

Summary:
Ref T8731. I think the issue is that some ProjectQuery (without needImages()) populates the query workspace, then the "real" one hits the workspace.

Instead, only populate the workspace from ObjectQuery, so we know that objects in the workspace always have whatever ObjectQuery attaches to them.

Test Plan: Verified this didn't destroy the cache hitrate, but I can't repro the original issue locally per se.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: chad, epriestley

Maniphest Tasks: T8731

Differential Revision: https://secure.phabricator.com/D13516

Details

Committed
epriestley <git@epriestley.com>Jul 1 2015, 23:22
Pushed
aubortJan 31 2017, 17:16
Parents
rPH28e0af5a62c8: Commenting on instances of a recurring event should create a new event with its…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd5e4d9608626: Don't put objects into the query workspace by default (authored by epriestley <git@epriestley.com>).Jul 1 2015, 23:22