Homec4science

Return HTTP 500, not HTTP 200, on exception pages

Authored by epriestley <git@epriestley.com> on Nov 6 2013, 00:25.

Description

Return HTTP 500, not HTTP 200, on exception pages

Summary: Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan: Added a fake throw new Exception() and verified I got an HTTP 500 response.

Reviewers: jamesr, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4064

Differential Revision: https://secure.phabricator.com/D7507

Details

Committed
epriestley <git@epriestley.com>Nov 6 2013, 00:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPHce48375951bd: Don't throw when user tries to use an empty password via HTTP auth
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd5f41ef70ed0: Return HTTP 500, not HTTP 200, on exception pages (authored by epriestley <git@epriestley.com>).Nov 6 2013, 00:25