Homec4science

Fix reading ad-hoc settings with no formal Settings object

Authored by epriestley <git@epriestley.com> on Jun 3 2016, 15:04.

Description

Fix reading ad-hoc settings with no formal Settings object

Summary:
Ref T4103. Some settings (like the collapsed/expanded state of the diff filetree) are currently ad-hoc. They weren't being read correctly.

Also, simplify the caching code a little bit.

Test Plan: Toggled filetree, reloaded page, got sticky behavior.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16021

Details

Committed
epriestley <git@epriestley.com>Jun 4 2016, 23:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHeb673fd783e4: Formalize and fully modularize settings panel groups
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd5f924b3fabb: Fix reading ad-hoc settings with no formal Settings object (authored by epriestley <git@epriestley.com>).Jun 4 2016, 23:39