Homec4science

Use Differential policy columns to drive policies

Authored by epriestley <git@epriestley.com> on Sep 26 2013, 21:36.

Description

Use Differential policy columns to drive policies

Summary:
Ref T603. Read policies out of policy columns.

When a revision is associated with a repository (which is currently never), require view access on the repository to see the revision (or, require the viewer to be the owner). This is a blanket "do the right thing" rule which should make Differential's default policies align with user expectations.

Future diffs will populate the repositoryPHID when a revision is created.

Test Plan: Tooled around Differential. None of this stuff does anything yet, so nothing very exciting happened.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7134

Details

Committed
epriestley <git@epriestley.com>Sep 26 2013, 21:36
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc458517cb4fe: Add viewPolicy, editPolicy, repositoryPHID columns to DifferentialRevision
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd61c931c7b38: Use Differential policy columns to drive policies (authored by epriestley <git@epriestley.com>).Sep 26 2013, 21:36