Homec4science

Phriction - fix a corner case on renaming a project

Authored by Bob Trahan <bob.trahan@gmail.com> on Jan 6 2014, 20:19.

Description

Phriction - fix a corner case on renaming a project

Summary: if you rename a project in such a way that the old slug and the new slug are the same, there are errors when the phriction document is updated. detect this case and don't bother updating the document since there is no change. Fixes Github issue 474.

Test Plan: made a project "testTest". Viewed the wiki page. Created the wiki page. Renamed the project "TestTest". Before patch, this error'd, post patch it works!

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7888

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Jan 6 2014, 20:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH66dd984db507: New icons for play, pause, etc.
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHd63e530608e9: Phriction - fix a corner case on renaming a project (authored by Bob Trahan <bob.trahan@gmail.com>).Jan 6 2014, 20:19