Homec4science

Fix construction of default settings for users with no settings at all

Authored by epriestley <git@epriestley.com> on Jun 14 2016, 00:19.

Description

Fix construction of default settings for users with no settings at all

Summary:
Ref T11098. Users with at least one setting set correctly fall back to the defaults, but users with no settings at all currently do not.

Make them fall back to global defaults properly.

Test Plan:

  • Set global defaults to some non-default setting.
  • Completely delete a user's settings.
  • bin/cache purge --purge-all or --purge-user.
  • View settings as the user.
    • Before change: showed hard-coded defaults instead of global defaults until you save anything.
    • After change: properly shows global defaults from the start.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11098

Differential Revision: https://secure.phabricator.com/D16112

Details

Committed
epriestley <git@epriestley.com>Jun 14 2016, 00:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPH65634781b44f: Don't re-mention users for comment edits
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd68b2cc0e4c4: Fix construction of default settings for users with no settings at all (authored by epriestley <git@epriestley.com>).Jun 14 2016, 00:50