Homec4science

Improve error messages when specifying bad set or list to bin/config

Authored by epriestley <git@epriestley.com> on Mar 2 2015, 16:51.

Description

Improve error messages when specifying bad set or list to bin/config

Summary: Fixes T7308. Multiple users have encountered confusion around how they should specify a set or list in JSON; provide examples.

Test Plan:

epriestley@orbital ~/dev/phabricator $ ./bin/config set files.image-mime-types true
Usage Exception: Config key 'files.image-mime-types' is of type 'set'. Specify it in JSON. For example:

    ./bin/config set '{"value1": true, "value2": true}'

epriestley@orbital ~/dev/phabricator $ ./bin/config set cluster.addresses true
Usage Exception: Config key 'cluster.addresses' is of type 'list<string>'. Specify it in JSON. For example:

    ./bin/config set '["a", "b", "c"]'

epriestley@orbital ~/dev/phabricator $

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7308

Differential Revision: https://secure.phabricator.com/D11925

Details

Committed
epriestley <git@epriestley.com>Mar 2 2015, 16:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2387c1e9186b: Allow un-ToS'd users to view other Legalpad documents
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd69a6b8490a5: Improve error messages when specifying bad set or list to bin/config (authored by epriestley <git@epriestley.com>).Mar 2 2015, 16:51