Homec4science

When file transforms race and lose, accept defeat gracefully

Authored by epriestley <git@epriestley.com> on May 21 2015, 18:42.

Description

When file transforms race and lose, accept defeat gracefully

Summary: Fixes T8277. Transforming files can race; resolve the race after we lose.

Test Plan:

  • Added sleep(10) near the bottom of the transform controller.
  • Transformed a file in two browser windows at the same time; got something like this (exception corresponds to the loser of the race):

{F412526}

  • Applied patch.
  • Repeated process, got this:

{F412527}

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8277

Differential Revision: https://secure.phabricator.com/D12965

Details

Committed
epriestley <git@epriestley.com>May 21 2015, 18:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa50de8958efb: Return empty array as a default value for repository symbol languages
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd70ca6b7c8b5: When file transforms race and lose, accept defeat gracefully (authored by epriestley <git@epriestley.com>).May 21 2015, 18:42