Homec4science

Change lock in PullLocalDaemon to only lock on discovery

Authored by Nick Harper <nharper@fb.com> on Jun 30 2012, 01:19.

Description

Change lock in PullLocalDaemon to only lock on discovery

Summary:
The locks held by read-only pullLocal daemons were causing our discovery instance
to not get the lock and fail at discovery. We don't need to hold the lock while
pulling (only while discovering), so this moves the lock to the appropriate place.

Test Plan: tested in production

Reviewers: jungejason, epriestley, vrana

Reviewed By: jungejason

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2890

Details

Committed
Nick Harper <nharper@fb.com>Jun 30 2012, 01:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH30b06c1ad05f: Diffusion: turn branches/refs properties into links
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPHd70f8dad3f37: Change lock in PullLocalDaemon to only lock on discovery (authored by Nick Harper <nharper@fb.com>).Jun 30 2012, 01:19