Homec4science

Fix binary/utf8 issues with Differential changeset parse cache

Authored by epriestley <git@epriestley.com> on May 18 2014, 01:34.

Description

Fix binary/utf8 issues with Differential changeset parse cache

Summary:
Fixes T4898. After we increased the strictness of the %s conversion, most serialize() output is rejected from the cache.

Drop the cache, change the column type to latin1_bin, and then use %B to mark the data as binary during query construction.

Test Plan: Viewed Differential, saw cache fills.

Reviewers: btrahan, spicyj

Reviewed By: spicyj

Subscribers: epriestley

Maniphest Tasks: T4898

Differential Revision: https://secure.phabricator.com/D9171

Details

Committed
epriestley <git@epriestley.com>May 18 2014, 01:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa74545c9da4b: Provide a rough, unstable API for reporting coverage into Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd744d5d85995: Fix binary/utf8 issues with Differential changeset parse cache (authored by epriestley <git@epriestley.com>).May 18 2014, 01:34