Homec4science

Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in…

Authored by epriestley <git@epriestley.com> on Dec 15 2015, 15:57.

Description

Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in comment actions

Summary:
Ref T9908. Fixes T6205.

This is largely some refactoring to improve the code. The new structure is:

  • Each EditField has zero or one "submit" (normal edit form) controls.
  • Each EditField has zero or one "comment" (stacked actions) controls.
    • If we want more than one in the future, we'd just add two fields.
  • Each EditField can have multiple EditTypes which provide Conduit transactions.
  • EditTypes are now lower-level and less involved on the Submit/Comment pathways.

Test Plan:

  • Added and removed projects and subscribers.
  • Changed task statuses.
  • In two windows: added some subscribers in one, removed different ones in the other. The changes did not conflict.
  • Applied changes via Conduit.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6205, T9908

Differential Revision: https://secure.phabricator.com/D14789

Details

Committed
epriestley <git@epriestley.com>Dec 16 2015, 00:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6c4c93a091fa: Allow login to be disabled for authentication providers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd7693a93b3c4: Provide "Change Projects" and "Change Subscribers" (instead of "Add ...") in… (authored by epriestley <git@epriestley.com>).Dec 16 2015, 00:03