Homec4science

Fix some repository URI handling issues in Git and Mercurial

Authored by epriestley <git@epriestley.com> on Dec 12 2013, 18:45.

Description

Fix some repository URI handling issues in Git and Mercurial

Summary:
See https://github.com/facebook/phabricator/issues/467. @dctrwatson also ran into an issue where we were trying to setPass() a GitURI.

  • For Git and Mercurial, properly generate credential URIs where relevant.
  • Don't try to setPass() on Git-style URIs.

This isn't perfect but should clean things up a bit.

Test Plan: Added unit tests. Lots of grep.

Reviewers: btrahan

Reviewed By: btrahan

CC: dctrwatson, aran

Differential Revision: https://secure.phabricator.com/D7759

Details

Committed
epriestley <git@epriestley.com>Dec 12 2013, 18:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1d9bf6f82b30: Fix Phortune so it allows users to create their accounts implicitly
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd846f6508b2c: Fix some repository URI handling issues in Git and Mercurial (authored by epriestley <git@epriestley.com>).Dec 12 2013, 18:45