Homec4science

Modernize architecture of `phd`

Authored by epriestley <git@epriestley.com> on Jul 19 2013, 00:28.

Description

Modernize architecture of phd

Summary:
Ref T1670. Mostly, use PhutilArgumentParser. This breaks up the mismash of functional stuff and PhabriatorDaemonControl into proper argumentparser Workflows.

There are no functional changes, except that I removed the "pingConduit()" call prior to starting daemons, because I intend to remove all Conduit integration.

Test Plan:

  • Ran phd list.
  • Ran phd status (running daemons).
  • Ran phd status (no running daemons).
  • Ran phd stop <pid> (dead task).
  • Ran phd stop <pid> (live task).
  • Ran phd stop zebra (invalid PID).
  • Ran phd stop 1 (bad PID).
  • Ran phd stop.
  • Ran phd debug zebra (no match).
  • Ran phd debug e (ambiguous).
  • Ran phd debug task.
  • Ran phd launch task.
  • Ran phd launch 0 task (invalid arg).
  • Ran phd launch 2 task.
  • Ran phd help.
  • Ran phd help list.
  • Ran phd start.
  • Ran phd restart.
  • Looked at Repositories (daemon running).
  • Looked at Repositories (daemon not running).

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1670

Differential Revision: https://secure.phabricator.com/D6490

Details

Committed
epriestley <git@epriestley.com>Jul 19 2013, 00:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdd76143399d8: Pholio - make the form maintain client side edits between file uploads
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd89b8ce2b2c8: Modernize architecture of `phd` (authored by epriestley <git@epriestley.com>).Jul 19 2013, 00:28