Homec4science

When importing Git repositories, treat out-of-range timestamps as the current…

Authored by epriestley <git@epriestley.com> on Aug 26 2016, 14:21.

Description

When importing Git repositories, treat out-of-range timestamps as the current time

Summary:
Fixes T11537. See that task for discussion.

Although we could accommodate these faithfully, it requires a huge migration and affects one repository on one install which was written with buggy tools.

At least for now, just replace out-of-32-bit-range epoch values with the current time, which is often somewhat close to the real value.

Test Plan:

  • Following the instructions in T11537, created commits in 40,000 AD.
  • Tried to import them, reproducing the "epoch" database issue.
  • Applied the patch.
  • Successfully imported future-commits, with some liberties around commit dates. Note that author date (not stored in an epoch column) is still shown faithfully:

{F1789302}

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T11537

Differential Revision: https://secure.phabricator.com/D16456

Details

Committed
epriestley <git@epriestley.com>Aug 26 2016, 16:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH72a03dc03e7d: Add a setup warning for "always_populate_raw_post_data"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd952dd591266: When importing Git repositories, treat out-of-range timestamps as the current… (authored by epriestley <git@epriestley.com>).Aug 26 2016, 16:38