Homec4science

Add comment linking to Maniphest and Differential

Authored by epriestley <git@epriestley.com> on May 31 2011, 19:23.

Description

Add comment linking to Maniphest and Differential

Summary:
Allows you to link to comments with "D123#3" or "T123#3", then adds a pile of JS
to try to make it not terrible. :/

The thing I'm trying to avoid here is when someone says "look at this!
http://blog.com/#comment-239291" and you click and your browser jumps somewhere
random and you have no idea which comment they meant. Since I really hate this,
I've tried to avoid it by making sure the comment is always highlighted.

Test Plan:
Put T1#1 and D1#1 in remarkup and verified they linked properly.

Clicked anchors on individual comments.

Faked all comments hidden in Differential and verified they expanded on anchor
or anchor change.

Reviewed By: aran
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, epriestley
Differential Revision: 383

Details

Committed
epriestley <git@epriestley.com>May 31 2011, 20:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPHead9bbfeb174: Test for pcntl availability from the command line, not Apache
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd96d515cc21e: Add comment linking to Maniphest and Differential (authored by epriestley <git@epriestley.com>).May 31 2011, 20:11