Homec4science

Use CSS to resize the lightboxed image instead of Javascript

Authored by epriestley <git@epriestley.com> on Oct 23 2012, 21:09.

Description

Use CSS to resize the lightboxed image instead of Javascript

Summary: We can let the browser do the scaling with some simpler CSS rules.

Test Plan: Opened very large images in Safari, Firefox and Chrome and resized the browser. Observed smooth scaling and no issues with the image overlapping UI elements, etc.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1896

Differential Revision: https://secure.phabricator.com/D3802

Details

Committed
epriestley <git@epriestley.com>Oct 23 2012, 21:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9dd918928396: Minor, move dialogs above masks.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd984a3ffa45d: Use CSS to resize the lightboxed image instead of Javascript (authored by epriestley <git@epriestley.com>).Oct 23 2012, 21:09