Homec4science

[Rough Sketch] Differential ObjectItemView Smexyness

Authored by Anh Nhan Nguyen <anhnhan@outlook.com> on Jul 2 2013, 21:14.

Description

[Rough Sketch] Differential ObjectItemView Smexyness

Summary:
Tried out PhabricatorObjectItemView for Differential. It looks smexy and smooth.

Refs T2014

  • Title and Date as Maniphest
  • Author in the handle icon
  • Bar color reflects revision status (Needs Review, Accepted, Abandoned etc.) @chad looking for non-blue is faster than keeping watch for everything that's not "Closed" in old table form
  • Some status information are in footer icons; currently only stale/old status display as well as saved drafts, maybe more in future; these come into my mind:
    • No reviewer warning
    • Push Blocking Priority (T2730)
    • Trivial, fast review guaranteed
    • Sketch / Just looking for advice/help
    • Arcanist Project (T2614)
    • Denote "Public Send-in" (T1476)

{F37662}
{F37663}
{F37664}
{F37665}

Some flaws:

  • Date and reviewers on every entry the same?
  • No respect for Differential fields (for some reason, every entry appeared the same, so broke it to parts)
  • Plenty of (potential) increase in height - advise reducing paging length from 100 to 50 - or just ignore me

Suggestions for the future:

  • Expand the meta information regarding revisions; e.g. the various status displays above
  • Uh... T2543, T1279, T793, T731 and what else I want for Differential, because they are awesome!
  • T793 should be in particular easy appearance-wise, just copy-paste from Maniphest

Test Plan: By looking at it, of course. Verified there are no errors or crashed

Reviewers: epriestley, chad, btrahan, liguobig

Reviewed By: chad

CC: aran, Korvin, edward, nh

Maniphest Tasks: T2014

Differential Revision: https://secure.phabricator.com/D5451

Conflicts:
src/__celerity_resource_map__.php

Details

Committed
epriestley <git@epriestley.com>Jul 3 2013, 15:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH23e18b1ca5c4: Provide PhabricatorSavedQuery to renderResultsList()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHd9f01d6fb7f5: [Rough Sketch] Differential ObjectItemView Smexyness (authored by Anh Nhan Nguyen <anhnhan@outlook.com>).Jul 3 2013, 15:10