Homec4science

Retry failed page anchor navigation

Authored by epriestley <git@epriestley.com> on Jan 6 2012, 01:36.

Description

Retry failed page anchor navigation

Summary:
When the user loads a page with an anchor on it like #thing, or clicks a link to
#thing, and #thing doesn't exist, keep trying to navigate to #thing for a few
seconds.

This allows anchors to work when the target is in content which is later ajaxed
in. In particular, this affects inline comments in Differential.

Test Plan: Opened inline comment links in a new tab, was in the right place when
I switched tabs.

Reviewers: nh, btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan, epriestley

Maniphest Tasks: T492

Differential Revision: https://secure.phabricator.com/D1327

Details

Committed
epriestley <git@epriestley.com>Jan 6 2012, 03:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9c5a6601d6b0: Remove some Mercurial and Google caveats
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHda3a97240044: Retry failed page anchor navigation (authored by epriestley <git@epriestley.com>).Jan 6 2012, 03:02