Homec4science

Fix ApplicationTransaction "no effect" error for mentions of already-mentioned…

Authored by epriestley <git@epriestley.com> on May 26 2013, 23:15.

Description

Fix ApplicationTransaction "no effect" error for mentions of already-mentioned users

Summary:
Fixes T3139. See that task for discussion.

If all mentions are removed because they're already subscribed, we currently generate an empty transaction, which later gets picked up as having no effect and the user gets yelled at.

Instead, don't generate a transaction if no PHIDs remain after filtering already-subscribed PHIDs.

Test Plan: Followed plan in T3139.

Reviewers: garoevans, btrahan

Reviewed By: garoevans

CC: aran

Maniphest Tasks: T3139

Differential Revision: https://secure.phabricator.com/D6048

Details

Committed
epriestley <git@epriestley.com>May 26 2013, 23:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH59bb8ca9dd84: Move Maniphest attached files section into textbox.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHda60c71fb8bc: Fix ApplicationTransaction "no effect" error for mentions of already-mentioned… (authored by epriestley <git@epriestley.com>).May 26 2013, 23:15