Homec4science

Use AphrontFormLayoutView, not AphrontFormView, for GitHub 'Repository'…

Authored by epriestley <git@epriestley.com> on Jul 24 2011, 21:28.

Description

Use AphrontFormLayoutView, not AphrontFormView, for GitHub 'Repository' interface

Summary:
See T58. When I originally wrote this interface you couldn't make a form that
looked like a form but wasn't really a form, so I made it a real form. That
meant you could hit "return" in the text input and submit the form, which didn't
do anything but is vaguely silly.

After D422 there's a layout-only form element, so switch to that.

Test Plan: Loaded the tab, hit return in the textarea, it didn't do a form
submit.
Reviewed By: jungejason
Reviewers: jungejason, tuomaspelkonen, aran
CC: aran, jungejason, epriestley
Differential Revision: 719

Details

Committed
epriestley <git@epriestley.com>Jul 25 2011, 03:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6e08a9215ddd: Move "Preferences" to "Settings"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHda8beefa6c0b: Use AphrontFormLayoutView, not AphrontFormView, for GitHub 'Repository'… (authored by epriestley <git@epriestley.com>).Jul 25 2011, 03:10