Homec4science

Don't synchronize Asana objects with no CCs and no responsible, non-author users

Authored by epriestley <git@epriestley.com> on Aug 12 2013, 20:20.

Description

Don't synchronize Asana objects with no CCs and no responsible, non-author users

Summary: Ref T2852. Currently, we publish commits with no audit requests and reviews with no CCs or reviewers into Asana. This creates undesired notifications, so drop events which would publish an object that doesn't exist yet and has no followers or respible users.

Test Plan: Used bin/feed republish to publish a story about an object with no related users, saw the publish abort with the new message. Added a CC, published again, got a publish.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6727

Details

Committed
epriestley <git@epriestley.com>Aug 12 2013, 20:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa0f0ba6acd47: Stop using process/filesystem-based checks to determine if daemons are running
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHda8ffbac1221: Don't synchronize Asana objects with no CCs and no responsible, non-author users (authored by epriestley <git@epriestley.com>).Aug 12 2013, 20:20