Homec4science

Do initial repository imports at a lower priority and finish importing commits…

Authored by epriestley <git@epriestley.com> on Sep 22 2016, 00:16.

Description

Do initial repository imports at a lower priority and finish importing commits before starting new ones

Summary:
Fixes T11677. This makes two minor adjustments to the repository import daemons:

  • The first step ("Message") now queues at a slightly-lower-than-default (for already-imported repositories) or very-low (for newly importing repositories) priority level.
  • The other steps now queue at "default" priority level. This is actually what they already did, but without this change their behavior would be to inherit the priority level of their parents.

This has two effects:

  • When adding new repositories to an existing install, they shouldn't block other things from happening anymore.
  • The daemons will tend to start one commit and run through all of its steps before starting another commit. This makes progress through the queue more even and predictable.
    • Before, they did ALL the message tasks, then ALL the change tasks, etc. This works fine but is confusing/uneven/less-predictable because each type of task takes a different amount of time.

Test Plan:

  • Added a new repository.
  • Saw all of its "message" steps queue at priority 4000.
  • Saw followups queue at priority 2000.
  • Saw progress generally "finish what you started" -- go through the queue one commit at a time, instead of one type of task at a time.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11677

Differential Revision: https://secure.phabricator.com/D16585

Details

Committed
epriestley <git@epriestley.com>Sep 22 2016, 01:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8941bbfcea7d: Make "text" custom fields appear in ApplicationSearch again
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdb2425b300fb: Do initial repository imports at a lower priority and finish importing commits… (authored by epriestley <git@epriestley.com>).Sep 22 2016, 01:41