Homec4science

Fix project hashtag regexp to stop matching terminal periods

Authored by epriestley <git@epriestley.com> on Oct 29 2014, 16:13.

Description

Fix project hashtag regexp to stop matching terminal periods

Summary:
Fixes T6416. The comment is consistent with intent, but the actual regexp doesn't quite work right. In particular, we incorrectly match #security. as security. (with a period) instead of security (with no period).

Since this stuff is a pain to test and I evidently got it wrong in this case in D8703, make it unit testable.

Test Plan:
Added unit tests. Also:

{F227181}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6416

Differential Revision: https://secure.phabricator.com/D10753

Details

Committed
epriestley <git@epriestley.com>Oct 29 2014, 16:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd5b70e2c1cab: Add AlmanacBinding, to bind a service to an interface
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdc6b988deac9: Fix project hashtag regexp to stop matching terminal periods (authored by epriestley <git@epriestley.com>).Oct 29 2014, 16:13