Homec4science

Fail quietly when failing to write access log

Authored by epriestley <git@epriestley.com> on May 10 2013, 01:08.

Description

Fail quietly when failing to write access log

Summary: See D5874. PhutilDeferredLog's exception on write()/__destruct() is not especially important and can come at an awkward time. Instead of throwing, just emit an error message to the log.

Test Plan: Faked failed writes and saw an error message in the log instead of many terrible things everywhere.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3144

Differential Revision: https://secure.phabricator.com/D5875

Details

Committed
epriestley <git@epriestley.com>May 10 2013, 01:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPH83109ff8afcd: Update Celerity
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdc6c1bf4351e: Fail quietly when failing to write access log (authored by epriestley <git@epriestley.com>).May 10 2013, 01:08