Homec4science

Move edit/deactivate operations onto project view page in Releeph

Authored by epriestley <git@epriestley.com> on Aug 20 2013, 03:30.

Description

Move edit/deactivate operations onto project view page in Releeph

Summary:
Ref T3092.

Releeph's objects basically go like this:

  • At the top level, we have Projects (like "www" or "libphutil")
  • Each project has Branches (like "LATEST" or "v1.1.3")
  • Each branch has Requests (like pull requests, e.g. "please merge commit X into branch Y (in project Z)")

Currently, there's no real "project detail" or "branch detail" page. Instead, we have a search results page for their contained objects. That is, the "project detail" page shows a list of branches in the project, using ApplicationSearch.

This means that operations like "edit" and "deactivate" are one level up, on the respective list pages.

Instead, move details onto the detail pages. This gives us more room for actions and information, and simplifies the list views.

Basically, these are "detail pages" where the object content is a search interface. We do something simliar to this in Phame right now, although it's messier there (no ApplicationSearch yet).

@chad, you might have some ideas here. Roughly, the design question is "How should we present an object's detail view when its content is really a search interface (Phame Blog for Posts, Releeph Project for Branches)?"

I think the simple approach I've taken here (see screenshot) gives us reasonable results, but overall it's something we haven't done much or done too much thinking about, I think.

Test Plan: {F54774}

Reviewers: btrahan

Reviewed By: btrahan

CC: chad, aran

Maniphest Tasks: T3092

Differential Revision: https://secure.phabricator.com/D6771

Details

Committed
epriestley <git@epriestley.com>Aug 20 2013, 03:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9ef0ea91c4a2: Remove dust pattern for common bg color.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHdcec8e60ccac: Move edit/deactivate operations onto project view page in Releeph (authored by epriestley <git@epriestley.com>).Aug 20 2013, 03:30